[ovs-dev] [PATCH 4/5] ofp-errors: Use OFPERR_OFPBRC_BAD_TABLE_ID
Ben Pfaff
blp at nicira.com
Tue Sep 4 20:18:57 UTC 2012
On Tue, Sep 04, 2012 at 03:52:02PM +0900, Simon Horman wrote:
> * In the case of OpenFlow 1.1+ OFPERR_OFPBRC_BAD_TABLE_ID is defined
> in the specification and seems to be the most appropriate error
> to use when an unknown table id is encountered.
>
> * In the case of OpenFlow 1.0 no appropriate error message
> seems to exist. Perhaps because an invalid port is not possible?
> I'm unsure.
>
> In any case, make use of a non-standard error code (1,512).
> This was formerly known as OFPERR_NXBRC_BAD_TABLE_ID but
> has been rolled into OFPERR_OFPBRC_BAD_TABLE_ID to allow the
> latter to be used without concern for the prevailing Open Flow version.
>
> Signed-off-by: Simon Horman <horms at verge.net.au>
Same issue about comments as patch 3, otherwise looks good.
Thank you.
More information about the dev
mailing list