[ovs-dev] [PATCH] dpif-linux: Report packet loss as WARN instead of ERR.

Ansis Atteka aatteka at nicira.com
Wed Sep 5 19:41:56 UTC 2012


On Wed, Sep 5, 2012 at 11:04 AM, Ben Pfaff <blp at nicira.com> wrote:
> Packet loss is recoverable so it doesn't warrant an ERR.
>
> Bug #12920.
> Reported-by: Scott Hendricks <shendricks at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  lib/dpif-linux.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
> index d9c50cc..a2eb490 100644
> --- a/lib/dpif-linux.c
> +++ b/lib/dpif-linux.c
> @@ -2002,7 +2002,7 @@ report_loss(struct dpif *dpif_, struct dpif_channel *ch)
>      }
>      ds_chomp(&s, ',');
>
> -    VLOG_ERR("%s: lost packet on channel %td%s",
> -             dpif_name(dpif_), ch - dpif->channels, ds_cstr(&s));
> +    VLOG_WARN("%s: lost packet on channel %td%s",
> +              dpif_name(dpif_), ch - dpif->channels, ds_cstr(&s));
>      ds_destroy(&s);
>  }
> --
> 1.7.2.5
>
Looks good to me. Thanks!



> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list