[ovs-dev] [PATCH 04/27] ofp-util: Allow decoding of Open Flow 1.1 & 1.2 Table Statistics Request Messages

Ben Pfaff blp at nicira.com
Fri Sep 7 17:34:06 UTC 2012


On Fri, Sep 07, 2012 at 09:06:23AM +0900, Simon Horman wrote:
> On Fri, Aug 31, 2012 at 05:42:48PM +0900, Simon Horman wrote:
> > On Thu, Aug 30, 2012 at 10:02:51AM +0900, Simon Horman wrote:
> > > On Wed, Aug 29, 2012 at 10:07:55AM -0700, Ben Pfaff wrote:
> > > > On Tue, Aug 21, 2012 at 01:55:36PM +0900, Simon Horman wrote:
> > > > > Signed-off-by: Simon Horman <horms at verge.net.au>
> > > > 
> > > > I'm not really happy with this approach.  It seems fairly awkward.  I
> > > > would much rather define some "struct ofputil_*" that has a superset of
> > > > the 1.[012] table stats and define converter functions.
> > > 
> > > Sure, I'll see what I can do.
> > > I do agree that the approach I have taken is somewhat awkward.
> > 
> > Hi Ben,
> > 
> > is this closer to what you would like?
> 
> Hi Ben,
> 
> could you take a moment to look over this?
> I'd like to know if this approach is appropriate.

Sorry, somehow I overlooked your earlier email.



More information about the dev mailing list