[ovs-dev] [PATCH] datapath: set the skb 'pkt_type' field
Jesse Gross
jesse at nicira.com
Fri Sep 7 18:28:35 UTC 2012
On Fri, Sep 7, 2012 at 5:23 AM, Tadaaki Nagao <nagao at stratosphere.co.jp> wrote:
> The datapath doesn't set the skb 'pkt_type' field for packets received
> from the userspace, and thus their pkt_type is always PACKET_HOST even
> for Ethernet broadcast and multicast packets. Though there don't seem
> to be many users of pkt_type in the Linux kernel, I encountered a
> third-party driver that relies on that field. This patch fixes this
> issue.
>
> Signed-off-by: Tadaaki Nagao <nagao at stratosphere.co.jp>
Can you please elaborate what the driver does with the field? Is this
on transmit? At the very least, I can't send this patch upstream with
the existing commit message because out-of-tree drivers aren't
supported so you'll have to provide justification that this is the
right thing to do in general.
The primary use of pkt_type is on receive and we currently call
eth_type_trans() when packets are received on internal devices. For
transmitted packets there are a number of cases where the packet type
can change - MAC modification/tunneling in OVS or pretty much anywhere
a packet is transmitted in the rest of Linux so don't think this patch
is sufficient there.
More information about the dev
mailing list