[ovs-dev] [PATCH 4/5] ofp-actions: encode OF12 output/set-field actions

[Simon Horman]

On Wed, Sep 12, 2012 at 12:06:50PM -0700, Ben Pfaff wrote:
> On Wed, Sep 12, 2012 at 05:44:31PM +0900, Simon Horman wrote:
> > From: Isaku Yamahata <yamahata at valinux.co.jp>
> > 
> > Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> I think that, if I'm reading this right, then attempting to convert
> many actions to OF1.2 will cause an assertion failure.  We need to do
> something more graceful than that.

Is the problem the use of NOT_REACHED() in ofpact_to_openflow12()
and ofpact_to_openflow12_common()?

If so, I wonder if the code could be re-factored to allow an error to be
returned.

I also notice that ofpacts_put_openflow12_actions() isn't actually used,
rather ofpacts_put_openflow11_actions is used for Open Flow 1.2, but that
should be easy enough to fix.