[ovs-dev] [PATCH 2/5] python/ovs/db/idl: counter part of ovsdb_idl_add_table() to SchemaHelper

Ben Pfaff blp at nicira.com
Thu Sep 13 03:43:03 UTC 2012


On Thu, Sep 13, 2012 at 11:22:53AM +0900, Isaku Yamahata wrote:
> On Wed, Sep 12, 2012 at 11:45:12AM -0700, Ben Pfaff wrote:
> > On Wed, Sep 12, 2012 at 03:17:22PM +0900, Isaku Yamahata wrote:
> > > add register_table method to SchemaHelper as counter part of
> > > ovsdb_idl_add_table().
> > > 
> > > Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>
> > 
> > This seems like a good idea, but would you mind adding a doc comment
> > and updating comments on other functions that refer to registration?
> > You can start from the comment on ovsdb_idl_add_column().
> 
> Here is the updated one.
> 
> From 273a8ddc99ebb60bc45c8f9f9d91cd124676c624 Mon Sep 17 00:00:00 2001
> Message-Id: <273a8ddc99ebb60bc45c8f9f9d91cd124676c624.1347502637.git.yamahata at valinux.co.jp>
> In-Reply-To: <cover.1347502636.git.yamahata at valinux.co.jp>
> References: <cover.1347502636.git.yamahata at valinux.co.jp>
> From: Isaku Yamahata <yamahata at valinux.co.jp>
> Date: Fri, 24 Aug 2012 15:13:49 +0900
> Subject: [PATCH] python/ovs/db/idl: counter part of ovsdb_idl_add_table() to SchemaHelper
> 
> add register_table method to SchemaHelper as counter part of
> ovsdb_idl_add_table().
> 
> Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>

Thanks.  I edited the commit log a little and pushed this to master.



More information about the dev mailing list