[ovs-dev] [PATCH 4/5] python/ovs/db/idl.py: Transaction._substitute doesn't handle list/tuple

Ben Pfaff blp at nicira.com
Thu Sep 13 03:56:41 UTC 2012


On Thu, Sep 13, 2012 at 11:30:23AM +0900, Isaku Yamahata wrote:
> From: Isaku Yamahata <yamahata at valinux.co.jp>
> Date: Mon, 10 Sep 2012 18:21:20 +0900
> Subject: [PATCH] python/ovs/db/idl.py: Transaction._substitute doesn't handle list/tuple
> 
> Since Transaction._substitute doesn't substitute elements of list/tuple,
> setting list references results in transaction error. Teach it such case.

That's a bad bug, and I'm surprised that we haven't caught it before.
But I think that there is still a bug: the C version of
substitute_uuids(), in ovsdb-idl.c, also recurses through JSON objects.
Doesn't the Python version need to, similarly, recurse through Python
dictionaries?

Thanks,

Ben.



More information about the dev mailing list