[ovs-dev] [multi-dbs 1/6] unixctl: Fix comment on unixctl_command_register().

Ethan Jackson ethan at nicira.com
Thu Sep 20 22:03:18 UTC 2012


Acked-by: Ethan Jackson <ethan at nicira.com>


On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff <blp at nicira.com> wrote:
> The arguments to the callback were changed some time ago but the comment
> still described the older form.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  lib/unixctl.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/lib/unixctl.c b/lib/unixctl.c
> index 4ab493d..8686de3 100644
> --- a/lib/unixctl.c
> +++ b/lib/unixctl.c
> @@ -95,13 +95,13 @@ unixctl_version(struct unixctl_conn *conn, int argc OVS_UNUSED,
>   * arguments to the command; it is used only for presentation to the user in
>   * "help" output.
>   *
> - * 'cb' is called when the command is received.  It is passed the actual set of
> - * arguments, as a text string, plus a copy of 'aux'.  Normally 'cb' should
> - * reply by calling unixctl_command_reply() or unixctl_command_reply_error()
> - * before it returns, but if the command cannot be handled immediately then it
> - * can defer the reply until later.  A given connection can only process a
> - * single request at a time, so a reply must be made eventually to avoid
> - * blocking that connection. */
> + * 'cb' is called when the command is received.  It is passed an array
> + * containing the command name and arguments, plus a copy of 'aux'.  Normally
> + * 'cb' should reply by calling unixctl_command_reply() or
> + * unixctl_command_reply_error() before it returns, but if the command cannot
> + * be handled immediately then it can defer the reply until later.  A given
> + * connection can only process a single request at a time, so a reply must be
> + * made eventually to avoid blocking that connection. */
>  void
>  unixctl_command_register(const char *name, const char *usage,
>                           int min_args, int max_args,
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list