[ovs-dev] [PATCH 1/2] netdev-vport: Fix ToS/TTL mixup in unparsing.

Jesse Gross jesse at nicira.com
Tue Sep 25 20:47:44 UTC 2012


When unparsing the kernel tunnel configuration, TTL was incorrectly
converted to "tos".  Although it leads to confusing configuration
output, actual operation is not affected.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 lib/netdev-vport.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index db5c3db..d5c288f 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -814,10 +814,10 @@ unparse_tunnel_config(const char *name OVS_UNUSED, const char *type OVS_UNUSED,
     }
 
     if (flags & TNL_F_TTL_INHERIT) {
-        smap_add(args, "tos", "inherit");
+        smap_add(args, "ttl", "inherit");
     } else if (a[OVS_TUNNEL_ATTR_TTL]) {
         int ttl = nl_attr_get_u8(a[OVS_TUNNEL_ATTR_TTL]);
-        smap_add_format(args, "tos", "%d", ttl);
+        smap_add_format(args, "ttl", "%d", ttl);
     }
 
     if (flags & TNL_F_TOS_INHERIT) {
-- 
1.7.9.5




More information about the dev mailing list