[ovs-dev] [set-field 0/4] set-field action support

[Simon Horman]

On Wed, Sep 26, 2012 at 09:21:13AM -0700, Ben Pfaff wrote:
> On Wed, Sep 26, 2012 at 09:27:53AM +0900, Simon Horman wrote:
> > On Tue, Sep 25, 2012 at 10:35:33AM -0700, Ben Pfaff wrote:
> > > This is an alternative to "[PATCH 2/3] ofp-actions: plumb of12 actions
> > > support", by Simon and Isaku, that I am putting forth because I prefer it.
> > > 
> > > Ben Pfaff (3):
> > >   openflow-1.2: Remove OFPAT12_* definitions that duplicate OFPAT11_*
> > >     ones.
> > >   ofp-actions: Prepare to treat OF1.2 actions as OF1.1 actions.
> > >   ofp-actions: Allow OF1.1+ actions to be variable-length.
> > > 
> > > Isaku Yamahata (1):
> > >   ofp-actions: Add support for OpenFlow 1.2 "set-field" action.
> > 
> > I am slightly surprised by allowing set-field actions
> > for OpenFlow 1.1 but this approach certainly is clean.
> 
> If we do want to be really strict (I don't personally see much value
> in it) then we could always add a simple filter based on action type
> and protocol version.

I'm happy with the approach implemented in this patch set,
just a little surprised at first.

> 
> > All patches:
> > 
> > Reviewed-by: Simon Horman <horms at verge.net.au>
> 
> Thanks.  I'll push this soon.

Thanks