[ovs-dev] [PATCH 3/4] ofproto-dpif: Push statistics less frequently.

Ben Pfaff blp at nicira.com
Mon Apr 1 22:54:08 UTC 2013


On Mon, Apr 01, 2013 at 03:50:22PM -0700, Ethan Jackson wrote:
> > Currently, I think, we push stats at least once a second.  This
> > reduces that to at least once every two seconds, I think.  Does
> > pushing once a second reduce performance?
> 
> It basically wipes out the benefit entirely.  If you feel that this
> approach is risky, I'd prefer to skip the patch entirely.  We'll need
> something like this in some unrelated series I'm working on.  Perhaps
> it can go in then.  After all this is just a temporary measure until
> the *correct* way to solve the problem appears. I.E. separate flow
> miss handling into it's own thread so these real time concerns stop
> being an issue. Thoughts?

You pointed out in person that this doesn't actually make the stats
update slower for flow-stats requests, since they get refreshed
on-demand.  So I think 2 seconds is fine.

Thanks,

Ben.



More information about the dev mailing list