[ovs-dev] [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages

Jesse Gross jesse at nicira.com
Tue Apr 2 23:30:43 UTC 2013


On Tue, Apr 2, 2013 at 3:28 PM, Thomas Graf <tgraf at suug.ch> wrote:
> The upcall port configured when adding a new datapath is currently
> only provided to user space as part of the vport message. Therefore
> user space has to request two separate messages which is prone to
> race conditions.
>
> Provide the upcall port of the local port (0) of a data path in the
> datapath message to gain symmetry between the SET and GET command.
>
> Signed-off-by: Thomas Graf <tgraf at suug.ch>

Can you describe the race condition some more?  The kernel doesn't
change the port ID on its own so even needing to request the value
seems rare.

Assigning the local ports upcall PID through datapath creation is
really somewhat of a hack since it's port state.  I don't disagree
that it's somewhat asymmetric now but it seems better to move away
from the current model if possible.



More information about the dev mailing list