[ovs-dev] [PATCH] ofproto-dpif: Disable miss handling in rule_get_stats().

Ben Pfaff blp at nicira.com
Sun Apr 7 00:25:14 UTC 2013


On Sat, Apr 06, 2013 at 03:33:13PM -0700, Ethan Jackson wrote:
> rule_get_stats() is often called when iterating over every rule in
> the flow table.  To ensure up-to-date statistics, rule_get_stats()
> calls push_all_stats() which can cause flow misses to be handled.
> When using the learn action, this can cause rules to be added (and
> potentially removed) from the OpenFlow table.  This could corrupt
> the caller's data structures, leading to a segmentation fault.
> This patch fixes the issue by disabling flow miss handling from
> within rule_get_stats().
> 
> Bug #15999.
> Signed-off-by: Ethan Jackson <ethan at nicira.com>

Thanks, looks good.



More information about the dev mailing list