[ovs-dev] [PATCH] netlink-socket: Don't bother logging SO_RCVBUFFORCE failure

Ansis Atteka aatteka at nicira.com
Thu Apr 11 19:45:15 UTC 2013


This patch fixes tests when they are run with "fakeroot debian/rules binary"
command.

The problem was that under fakeroot setsockopt() call could still return
EPERM and lead to a warning message being logged.

Signed-off-by: Ansis Atteka <aatteka at nicira.com>
---
 lib/netlink-socket.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index e6b10a1..392bcf5 100644
--- a/lib/netlink-socket.c
+++ b/lib/netlink-socket.c
@@ -130,7 +130,7 @@ nl_sock_create(int protocol, struct nl_sock **sockp)
                    &rcvbuf, sizeof rcvbuf)) {
         /* Only root can use SO_RCVBUFFORCE.  Everyone else gets EPERM.
          * Warn only if the failure is therefore unexpected. */
-        if (errno != EPERM || !getuid()) {
+        if (errno != EPERM) {
             VLOG_WARN_RL(&rl, "setting %d-byte socket receive buffer failed "
                          "(%s)", rcvbuf, strerror(errno));
         }
-- 
1.7.9.5




More information about the dev mailing list