[ovs-dev] [PATCH] ofproto: Don't report hidden flows in table stats.

[Justin Pettit]

On Apr 18, 2013, at 9:28 AM, Ben Pfaff <blp at nicira.com> wrote:

> But I'm not sure about the test.  It tries to connect to the default
> OpenFlow port on localhost.  I guess that there will ordinarily be no
> OpenFlow controller listening there.  Does the test still pass if there
> is, though?  And assuming that it does, do we think that it is OK to do
> that in the unit tests?  It could at least surprise the administrator of
> that controller, if there is one.

Do you have a better suggestion?  All the hidden flows I see are based on a controller being set.

> Also, I spent some time staring at the code that generates the second
> version of expout in the test.  I couldn't figure out what actually
> changes.  What is the difference between the pre-"set-controller" and
> post-"set-controller" output of "dump-tables"?

Nothing changes, which is the point.  If I take out my change, the test fails because there are eight or so flows that are added based on in-band.  I'm assuming that if there were a non-hidden flow in there, it would be counted, since earlier tests check for that.  I agree that the comparison is a bit confusing, since before and after are handled differently, but I just copied the behavior from a prior test.  Is there a different way you think I should handle it?

--Justin