[ovs-dev] [PATCH] hotplug: add openvswitch script

[Ian Campbell]

On Thu, 2013-04-18 at 19:01 +0100, Ben Pfaff wrote:
> On Thu, Apr 18, 2013 at 01:08:40PM +0100, Ian Campbell wrote:
> > On Thu, 2013-04-18 at 12:50 +0100, Ian Campbell wrote:
> > > Based on Waldi's RFC at
> > > http://lists.xen.org/archives/html/xen-devel/2012-09/msg00943.html
> > > 
> > > To use it set vif.default.script="vif-openvswitch" in /etc/xen/xl.conf or use
> > > script=vif-openvswitch in the vif configuration.
> > > 
> > > Appears to do the right thing for PV and HVM guests (including tap devices)
> > > and with stubdomains.
> > > 
> > > In order to support VLAN tagging and trunking the "bridge" specified in the
> > > configuration can have a special syntax, that is:
> > > 
> > > 	BRIDGE_NAME[.VLAN][:TRUNK,TRUNK]
> > > 
> > > e.g.
> > > - xenbr0.99
> > >      add the VIF to VLAN99 on xenbr0
> > > - xenbr0:99,100,101
> > >      add the VIF to xenbr0 as a trunk port receiving VLANs 99, 100 & 101
> > > 
> > > Waldi, can you confirm if I have correctly reverse engineered the syntax from
> > > the regexp please ;-)
> > 
> > I've done this as a Xen patch, but in principal this could also be
> > maintained in the openvswitch tree (I've added their list to the CC,
> > having forgotten it with the initial posting). Anyone have any strong
> > preference for one home over the other?
> 
> It looks to me like the proposed script uses only Open vSwitch
> interfaces (via ovs-vsctl) that have been stable for a long time.

I must confess it never even occurred to me to consider the stability of
this interface, but thanks for considering it and confirming!

>   My
> guess is that Xen users will be more likely to easily find this script
> if it is in the Xen distribution than if it is in the Open vSwitch one.
> So I would be inclined to believe that Xen is the right place for it.
> 
> That said, we'd be happy to include it with OVS if you think the balance
> falls the other way.

I think you are correct in your guess. Lets take it into the Xen tree
then.

Thanks,
Ian.