[ovs-dev] [PATCH 01/22] fix an obvious mistake in a test of IFM_ETHER

YAMAMOTO Takashi yamt at mwd.biglobe.ne.jp
Mon Apr 22 13:19:59 UTC 2013


fix a bug in FreeBSD code.  the fix is suggested by Ed Maste.

Signed-off-by: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>
---
 lib/netdev-bsd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index f46eee8..e3461b8 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -1037,7 +1037,7 @@ netdev_bsd_get_features(const struct netdev *netdev,
     media_list = xcalloc(ifmr.ifm_count, sizeof(int));
     ifmr.ifm_ulist = media_list;
 
-    if (!IFM_TYPE(ifmr.ifm_current) & IFM_ETHER) {
+    if (IFM_TYPE(ifmr.ifm_current) != IFM_ETHER) {
         VLOG_DBG_RL(&rl, "%s: doesn't appear to be ethernet",
                     netdev_get_name(netdev));
         error = EINVAL;
-- 
1.8.0.1




More information about the dev mailing list