[ovs-dev] [PATCH 15/22] add minimal NetBSD support

Ben Pfaff blp at nicira.com
Wed Apr 24 15:47:16 UTC 2013


On Wed, Apr 24, 2013 at 10:39:23AM -0400, Ed Maste wrote:
> I have only one overall comment: I personally don't like the style of
> platform-specific #if #elif cases within the function definition,
> where none of the body is common to the implementations.  I'll comment
> on the two cases (netdev_bsd_get_stats and set_etheraddr) in a reply
> to the specific patch that introduces them.  That said, I don't really
> have a better idea here, since I don't think the differences (yet)
> justify creating a netdev-freebsd.c and netdev-netbsd.c.  Perhaps just
> go with the current approach unless and until another BSD port comes
> along.
> 
> Ben, any comment on this, with respect to general OVS coding style?

I agree.  I don't have a better idea here either.



More information about the dev mailing list