[ovs-dev] [PATCH 2/2] Update comments to reflect per-bridge sFlow sampling

Neil Mckee neil.mckee at inmon.com
Tue Apr 30 19:04:44 UTC 2013


Update comments to reflect per-bridge sFlow sampling.

---
 ofproto/ofproto-dpif.c | 6 +++++-
 ofproto/tunnel.c       | 1 -
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 3ae3532..4306d40 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -1782,7 +1782,11 @@ port_construct(struct ofport *port_)
     port->carrier_seq = netdev_get_carrier_resets(netdev);
 
     if (netdev_vport_is_patch(netdev)) {
-        /* XXX By bailing out here, we don't do required sFlow work. */
+        /* By bailing out here, we don't submit the port to the sFlow module
+	 * to be considered for counter polling export.  This is correct
+	 * because the patch port represents an interface that sFlow considers
+	 * to be "internal" to the switch as a whole, and therefore not an
+	 * candidate for counter polling. */
         port->odp_port = OVSP_NONE;
         return 0;
     }
diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
index 8aa7fbe..8d29184 100644
--- a/ofproto/tunnel.c
+++ b/ofproto/tunnel.c
@@ -32,7 +32,6 @@
 
 /* XXX:
  *
- * Ability to generate metadata for packet-outs
  * Disallow netdevs with names like "gre64_system" to prevent collisions. */
 
 VLOG_DEFINE_THIS_MODULE(tunnel);
-- 
1.8.1.4




More information about the dev mailing list