[ovs-dev] [PATCH 2/2] Update comments to reflect per-bridge sFlow sampling

Ben Pfaff blp at nicira.com
Tue Apr 30 23:04:38 UTC 2013


On Tue, Apr 30, 2013 at 04:01:41PM -0700, Jesse Gross wrote:
> On Tue, Apr 30, 2013 at 3:49 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Apr 30, 2013 at 12:04:44PM -0700, Neil Mckee wrote:
> >> diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
> >> index 8aa7fbe..8d29184 100644
> >> --- a/ofproto/tunnel.c
> >> +++ b/ofproto/tunnel.c
> >> @@ -32,7 +32,6 @@
> >>
> >>  /* XXX:
> >>   *
> >> - * Ability to generate metadata for packet-outs
> >>   * Disallow netdevs with names like "gre64_system" to prevent collisions. */
> >
> > Why does this patch delete this comment?  (Is the comment incorrect to
> > begin with, or does patch 1/2 really somehow change something in this
> > area?)
> 
> The functionality listed here was intended to support sFlow for tunnel
> ports. However, the previous patch removes the ability to identify
> particular tunnel ports (well, it was already broken). I asked him to
> remove the comment if we go in that direction.

I see, thank you.



More information about the dev mailing list