[ovs-dev] [PATCH 3/3] datapath: Accept any 802.2 eth_type mask but override to be exact match

Jesse Gross jesse at nicira.com
Thu Aug 1 16:20:38 UTC 2013


On Wed, Jul 31, 2013 at 8:39 PM, Andy Zhou <azhou at nicira.com> wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index a2111e7..6fc09c2 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -1401,6 +1401,9 @@ static int ovs_key_from_nlattrs(struct sw_flow_match *match,  u64 attrs,
>                 SW_FLOW_KEY_PUT(match, eth.type, htons(ETH_P_802_2), is_mask);
>         }
>
> +       if (is_mask && match->key->eth.type == htons(ETH_P_802_2))
> +               SW_FLOW_KEY_PUT(match, eth.type, htons(0xffff), is_mask);

I have the same thoughts here as with the input port - we should be
able to drop the mask check and allow full wildcards.



More information about the dev mailing list