[ovs-dev] [PATCH] bridge.c: Invoke async_append_enable() in bridge_init()

[Ben Pfaff]

I sent out a counterproposal:
        http://openvswitch.org/pipermail/dev/2013-August/030288.html
Please review it, if you have time.

Is there a bug # for this?  If so, I will add it to the commit message.

On Fri, Aug 02, 2013 at 04:47:39PM -0700, Alex Wang wrote:
> No problem, I'm also not sure if that is the right place or way.
> 
> Thanks,
> Alex Wang,
> 
> 
> On Fri, Aug 2, 2013 at 4:45 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Fri, Aug 02, 2013 at 03:47:45PM -0700, Alex Wang wrote:
> > > Commit a5fb0e29a9c56 (vlog: Use async I/O.) invokes the function
> > > async_append_enable() in bridge_run(). This may cause the abortion
> > > of ovs-vswitchd since async_append_enable() must be invoked while
> > > single-threaded. And it is possible that system-state.c spawns a
> > > thread before the invocation.
> > >
> > > This commit fixes the bug by invoking async_append_enable() in
> > > bridge_init().
> > >
> > > Reported-by: Shih-Hao Li <shihli at nicira.com>
> > > Signed-off-by: Alex Wang <alexw at nicira.com>
> >
> > I agree that this fixes the problem, but it doesn't solve it the way I'd
> > prefer.  I'll write up an alternative patch for consideration.
> >