[ovs-dev] [PATCH 2/2] ofproto-dpif-xlate: Don't trace on deep resubmit.

Ethan Jackson ethan at nicira.com
Sat Aug 3 19:58:55 UTC 2013


I changed the commit message to this:

While this code is useful for debugging, removing it allows us to hide
ofproto_trace() in ofproto-dpif. ofproto_trace() is a complex function
which could be difficult to make "obviously" thread safe.

Thanks for the review,
Ethan

On Fri, Aug 2, 2013 at 10:25 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Aug 02, 2013 at 10:14:02PM -0700, Ethan Jackson wrote:
>> > I thought we introduced this to make debugging easier in real problem
>> > situations.  It would be pretty easy to make thread safe with an
>> > atomic_bool.
>>
>> I'm more worried about accessing the ofproto_trace() function from
>> outside of ofproto_dpif.  I'm trying to keep the interface in
>> ofproto-dpif.h small, simple, and easy to lock down from a concurrency
>> perspective.  Perhaps removing the feature altogether is overkill, but
>> I'm not sure of the trade offs either way.
>
> That reads to me as better rationale, please mention it in the commit
> message.
>
> Acked-by: Ben Pfaff <blp at nicira.com>
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list