[ovs-dev] [PATCH] BFD: Populate ToS field in BFD packets.

Ethan Jackson ethan at nicira.com
Sun Aug 4 18:10:04 UTC 2013


This looks good, can I have your signed-off-by please?

Thanks,
Ethan

On Fri, Jul 19, 2013 at 4:17 PM, Pavithra Ramesh <paramesh at vmware.com> wrote:
> ---
>  lib/bfd.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/bfd.c b/lib/bfd.c
> index 3ac257a..a36b8f3 100644
> --- a/lib/bfd.c
> +++ b/lib/bfd.c
> @@ -16,6 +16,7 @@
>  #include "bfd.h"
>
>  #include <arpa/inet.h>
> +#include <netinet/ip.h>
>
>  #include "byte-order.h"
>  #include "csum.h"
> @@ -55,9 +56,7 @@ VLOG_DEFINE_THIS_MODULE(bfd);
>   *
>   * - Unit tests.
>   *
> - * - BFD show into ovs-bugtool.
> - *
> - * - Set TOS/PCP on inner BFD frame, and outer tunnel header when encapped.
> + * - Set TOS/PCP on the outer tunnel header when encapped.
>   *
>   * - Sending BFD messages should be in its own thread/process.
>   *
> @@ -407,7 +406,8 @@ bfd_put_packet(struct bfd *bfd, struct ofpbuf *p,
>      ip = ofpbuf_put_zeros(p, sizeof *ip);
>      ip->ip_ihl_ver = IP_IHL_VER(5, 4);
>      ip->ip_tot_len = htons(sizeof *ip + sizeof *udp + sizeof *msg);
> -    ip->ip_ttl = 255;
> +    ip->ip_ttl = MAXTTL;
> +    ip->ip_tos = IPTOS_LOWDELAY | IPTOS_THROUGHPUT;
>      ip->ip_proto = IPPROTO_UDP;
>      ip->ip_src = htonl(0xA9FE0100); /* 169.254.1.0 Link Local. */
>      ip->ip_dst = htonl(0xA9FE0101); /* 169.254.1.1 Link Local. */
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list