[ovs-dev] [seq 4/5] seq: New module for race-free, pollable, thread-safe sequence number.

Ethan Jackson ethan at nicira.com
Thu Aug 8 07:30:48 UTC 2013


> I forgot to mention that they have to go after the parameters if they
> mention a parameter name, so that's a more general location.

Ah yes, then I prefer after.  Consistency is good.

Ethan

>
> On Aug 8, 2013 12:21 AM, "Ethan Jackson" <ethan at nicira.com> wrote:
>>
>> > GCC function attributes (and Clang attributes since the syntax is
>> > compatible) can go in either place.  Since you prefer them after the
>> > parameters I moved them.  I'll try to remember to put them there from
>> > now on.
>>
>> I don't have a preference, I just seem to remember them not working
>> when placed there.  I must have remembered incorrectly.  Now that I
>> think about it, the way you've done it is probably better have we have
>> more space after the return type anywyas.
>>
>> Ethan
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list