[ovs-dev] [PATCH v4 2/4] datapath: Add SCTP support

Jesse Gross jesse at nicira.com
Fri Aug 9 21:04:50 UTC 2013


On Fri, Aug 9, 2013 at 2:01 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Aug 09, 2013 at 01:45:19PM -0700, Jesse Gross wrote:
>> On Fri, Aug 9, 2013 at 1:17 PM, Ben Pfaff <blp at nicira.com> wrote:
>> > On Wed, Aug 07, 2013 at 03:55:49PM -0700, Jesse Gross wrote:
>> >> On Tue, Jul 30, 2013 at 5:31 PM, Joe Stringer <joe at wand.net.nz> wrote:
>> >> > This patch adds support for rewriting SCTP src,dst ports similar to the
>> >> > functionality already available for TCP/UDP.
>> >> >
>> >> > Rewriting SCTP ports is expensive due to double-recalculation of the
>> >> > SCTP checksums; this is performed to ensure that packets traversing OVS
>> >> > with invalid checksums will continue to the destination with any
>> >> > checksum corruption intact.
>> >> >
>> >> > Reviewed-by: Simon Horman <horms at verge.net.au>
>> >> > Signed-off-by: Joe Stringer <joe at wand.net.nz>
>> >>
>> >> Ben, I think you're planning on handling the rest of this patchset but
>> >> this one looks good to me.
>> >>
>> >> Acked-by: Jesse Gross <jesse at nicira.com>
>> >
>> > Jesse, this patch gives me sparse warnings building against Linux
>> > 3.2.0:
>> >
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31: warning: incorrect type in argument 1 (different base types)
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:    expected restricted __be32 [usertype] crc32
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:    got unsigned int [unsigned] [assigned] [usertype] crc32
>> > include/net/sctp/checksum.h:82:16: warning: cast from restricted __be32
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31: warning: incorrect type in argument 1 (different base types)
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:    expected restricted __be32 [usertype] crc32
>> > /home/blp/ovs/_build/../datapath/linux/compat/include/net/sctp/checksum.h:24:31:    got unsigned int [unsigned] [assigned] [usertype] crc32
>> > include/net/sctp/checksum.h:82:16: warning: cast from restricted __be32
>>
>> Joe mentioned that this is due to a bug in the kernel headers that has
>> been fixed upstream:
>>
>> "This patch introduces sparse warnings in some cases when calling
>> sctp_end_cksum(), due to a bug that was fixed in v3.10:
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=eee1d5a14780b9391ec51f3feaf4cffb521ddbb1"
>
> Then do you mind if I fold in this incremental as I apply it?  I don't
> like having new sparse warnings appear when I can avoid them.

That looks fine to me.
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list