[ovs-dev] [PATCH] netdev-linux: Fix netdev leak in corner case.

Ben Pfaff blp at nicira.com
Sun Aug 11 03:41:57 UTC 2013


Thank you, I applied this to master.

On Sat, Aug 10, 2013 at 11:03:48AM -0700, Alex Wang wrote:
> Looks good to me, Thanks,
> 
> 
> On Sat, Aug 10, 2013 at 9:04 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > Reported-by: Alex Wang <alexw at nicira.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/netdev-linux.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> > index e569750..d146ccf 100644
> > --- a/lib/netdev-linux.c
> > +++ b/lib/netdev-linux.c
> > @@ -513,9 +513,8 @@ netdev_linux_run(void)
> >                      ovs_mutex_lock(&netdev->mutex);
> >                      netdev_linux_update(netdev, &change);
> >                      ovs_mutex_unlock(&netdev->mutex);
> > -
> > -                    netdev_close(netdev_);
> >                  }
> > +                netdev_close(netdev_);
> >              }
> >          } else if (error == ENOBUFS) {
> >              struct shash device_shash;
> > --
> > 1.7.10.4
> >
> >



More information about the dev mailing list