[ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

Ethan Jackson ethan at nicira.com
Tue Aug 13 00:25:51 UTC 2013


At any rate this isn't an issue.  I have simply unlocked and destroyed
the rule after it's been removed from the classifier.

Ethan

On Tue, Aug 13, 2013 at 7:48 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Aug 12, 2013 at 01:23:38PM +0900, YAMAMOTO Takashi wrote:
>> > This patch uses a read-write lock to prevent rules from being evicted
>> > while they're used by child threads.  It also changes the prototypes
>> > of the various rule lookup functions so that the thread safety
>> > analysis can be used to ensure that the locking is handled properly.
>>
>> destroying a rwlock which is currently held is an undefined behaviour.
>> on NetBSD, pthread_rwlock_destroy fails in that case.
>
> I'm aware it's undefined.  I let this slip in by mistake.  Sorry about
> that, and thanks for the fix.
X-CudaMail-Whitelist-To: dev at openvswitch.org



More information about the dev mailing list