[ovs-dev] [PATCH] ovsdb: Add new column to set the maximum number of worker threads

[Alex Wang]

Thanks for the review, will work on this after I send the bfd decay patch
later this evening.


On Tue, Aug 13, 2013 at 6:24 PM, Ethan Jackson <ethan at nicira.com> wrote:

> Now that multithreading is in.  Could you rework this patch to
> actually reconfigure the ofproto-dpif-upcall module with the
> appropriate setting?  Basically the udpif_recv_set() function needs to
> be called with the appropriate value on boot, and whenever the setting
> changes.
>
> I don't see any particular reason to enforce a maximum for the value.
> If a user wants to configure 300 threads, why not let them?  It would
> be rather silly from a performance perspective, but the maximum seems
> rather arbitrary.
>
> It looks like in this code the default value is 1.  I'd prefer it
> actually be max_online_cores - 1.  I don't expect most users will
> actually set this, so let's default to good performance.
>
> > +        n_worker_threads = MAX(1, max_online_cores - 2);
>
> Since max_online_cores is unsigned, max_online_cores - 2 will be a
> very large number if max_online_cores < 2.  I.E this is a bug.
>
> Ethan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20130813/2862ba6d/attachment-0003.html>