[ovs-dev] [PATCH] ovsdb: Add "n-handler-threads" to Open_vSwitch TABLE.

[Ben Pfaff]

Applied, thanks.

On Thu, Aug 15, 2013 at 04:05:15PM -0700, Alex Wang wrote:
> This looks good, thanks Ben,
> 
> 
> On Thu, Aug 15, 2013 at 3:49 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > I think that the documentation can be improved.  What do you think of
> > this incremental?
> >
> > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> > index 8c7d082..5bbe943 100644
> > --- a/vswitchd/vswitch.xml
> > +++ b/vswitchd/vswitch.xml
> > @@ -160,16 +160,18 @@
> >        </column>
> >
> >        <column name="other_config" key="n-handler-threads"
> > -              type='{"type": "integer", "minInteger": 0}'>
> > +              type='{"type": "integer", "minInteger": 1}'>
> >          <p>
> > -          Specifies the number of upcall handler threads that will be
> > created
> > -          by the ofproto-dpif-upcall module.  The default value is
> > (number of
> > -          online core - 1).
> > +          Specifies the number of threads for software datapaths to use
> > for
> > +          handling new flows.  The default is one less than the number of
> > +          online CPU cores (but at least 1).
> >          </p>
> >          <p>
> > -          Note, the n-handler-threads configuration is per datapath and
> > -          not global to the switch.  It is best to use only one type of
> > -          datapath.
> > +          This configuration is per datapath.  If you have more than one
> > +          software datapath (e.g. some <code>system</code> bridges and
> > some
> > +          <code>netdev</code> bridges), then the total number of threads
> > is
> > +          <code>n-handler-threads</code> times the number of software
> > +          datapaths.
> >          </p>
> >        </column>
> >      </group>
> >