[ovs-dev] [clang 3/4] ofproto-dpif: Mark rule_release() as no_thread_safety_analysis.
Ben Pfaff
blp at nicira.com
Wed Aug 21 20:01:51 UTC 2013
Otherwise new Clang complains about this function because it only sometimes
releases the lock (that is, it only does it when there is a lock to
release).
I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
ofproto/ofproto-dpif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 6f87aa6..4f1da53 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -4838,6 +4838,7 @@ choose_miss_rule(enum ofputil_port_config config, struct rule_dpif *miss_rule,
void
rule_release(struct rule_dpif *rule)
+ OVS_NO_THREAD_SAFETY_ANALYSIS
{
if (rule) {
ovs_rwlock_unlock(&rule->up.evict);
--
1.7.10.4
More information about the dev
mailing list