[ovs-dev] Reinterpret base for meter band types bitmap.

[Ben Pfaff]

On Wed, Aug 21, 2013 at 11:26:13AM -0700, Jarno Rajahalme wrote:
> On Aug 12, 2013, at 9:57 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > OpenFlow 1.3 says that the band_types member of struct ofp_meter_features
> > is a bitmap of OFPMBT_* values.  The OFPMBT_* values are 1-based, so
> > until now, to avoid wasting bit 0, OVS mapped an OFPMBT_* with value 1 to
> > bit 0, value 2 to bit 1, and so on.  However, according to
> > http://openvswitch.org/pipermail/dev/2013-July/029666.html,
> > other OpenFlow implementations directly translate value 1 to bit 1,
> > value 2 to bit 2, and so on.  This commit changes Open vSwitch to use this
> > more common interpretation.
> > 
> > A request for clarification of this issue in the OpenFlow standard has been
> > filed with the ONF Extensibility Working Group as issue EXT-345.
> > 
> 
> Should have raised the issue while I was writing that..
> 
> > Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > 
> 
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

Thanks, applied to master.