[ovs-dev] [PATCH] ofproto-dpif: add thread-safety annotation to vsp_{remove, add}

[Simon Horman]

On Thu, Aug 22, 2013 at 09:41:00AM -0700, Ben Pfaff wrote:
> On Thu, Aug 22, 2013 at 02:30:10PM +0900, Simon Horman wrote:
> > This corrects an minor oversight in "ofproto-dpif: Make vlan splinters thread
> > safe." which add thread-safety to these functions.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Doesn't compile:
> 
> ../ofproto/ofproto-dpif.c:6179:18: error: use of undeclared identifier 'ofproto'
>     OVS_EXCLUDED(ofproto->vsp_mutex)
>                  ^
> ../lib/compiler.h:128:57: note: expanded from macro 'OVS_EXCLUDED'
> #define OVS_EXCLUDED(...) __attribute__((locks_excluded(__VA_ARGS__)))
>                                                         ^
> ../ofproto/ofproto-dpif.c:6200:18: error: use of undeclared identifier 'ofproto'
>     OVS_EXCLUDED(ofproto->vsp_mutex)
>                  ^
> ../lib/compiler.h:128:57: note: expanded from macro 'OVS_EXCLUDED'
> #define OVS_EXCLUDED(...) __attribute__((locks_excluded(__VA_ARGS__)))

Thanks. which version of clang do I need to show this up?