[ovs-dev] [PATCH] ofproto: remove the extra reset to make code clear to read.

Ben Pfaff blp at nicira.com
Fri Aug 23 18:23:25 UTC 2013


On Thu, Aug 22, 2013 at 02:09:57PM -0700, Jarno Rajahalme wrote:
> 
> On Aug 22, 2013, at 1:59 PM, pritesh <pritesh.kothari at cisco.com> wrote:
> 
> > Signed-off-by: pritesh <pritesh.kothari at cisco.com>
> > ---
> > ofproto/tunnel.c |    1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
> > index 0ba0066..202358b 100644
> > --- a/ofproto/tunnel.c
> > +++ b/ofproto/tunnel.c
> > @@ -457,7 +457,6 @@ tnl_find(struct tnl_match *match_) OVS_REQ_RDLOCK(rwlock)
> >     }
> > 
> >     /* Flow-based everything */
> > -    match.ip_src = 0;
> >     match.ip_src_flow = true;
> >     tnl_port = tnl_find_exact(&match);
> >     if (tnl_port) {
> > -- 
> > 1.7.9.5
> > 
> 
> Looks right, as the ip_src field is already zeroed couple of lines above.
> 
> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

Applied, thanks.



More information about the dev mailing list