[ovs-dev] [PATCH 1/2 v2] ofproto-dpif.at: Remove push_vlan from an OF1.0 test.

Ben Pfaff blp at nicira.com
Tue Aug 27 17:00:54 UTC 2013


On Mon, Aug 26, 2013 at 01:39:37PM -0700, Jarno Rajahalme wrote:
> Remove push_vlan from an OF1.0 test, as it requires OF1.1+ support, but was
> silently discarded.  A later patch will make this test to fail due to
> validation of usable OpenFlow protocol versions while parsing actions.
> 
> It should be noted that existing controllers may depend on the silently
> discarded push_vlan being accepted during the action validation code at the
> switch, as OpenFlow 1.0 supports setting a vlan ID, which will implicitly
> push a vlan header, if it did not exist already.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Applied, thanks.



More information about the dev mailing list