[ovs-dev] [PATCH 1/1] ofproto-dpif: Fix for out-of-order packets in upcalls processing

Ben Pfaff blp at nicira.com
Wed Aug 28 06:06:02 UTC 2013


On Wed, Jul 24, 2013 at 04:59:34PM +0300, Dmitry Fleytman wrote:
> From: Dmitry Fleytman <dfleytma at redhat.com>
> 
> User mode logic groups incoming packets by flows and then
> process flows in arbitrary order based on flow hash keys values.
> This behavior may lead to unexpected packets reordering. For example
> two packets that belong to the same "logical stream" and differ
> by ECN bit only placed to different flows and may be transmitted
> in reverse order.
> 
> This patch removes connection between packets classification and
> packets transmission order to ensure proper order for outgoing packets.

I finally got around to looking this over.  Sorry about the delay, we've
been rewriting everything.

The problem looks real enough to me, the patch is not too bad
either--but we've changed all the code that the patch touches almost
entirely.  I'm going to rework it myself and send it out for review as
soon as I can.

Thanks,

Ben.



More information about the dev mailing list