[ovs-dev] [groups v2 2/2] Implement OpenFlow 1.1+ "groups" protocol.

[Ben Pfaff]

On Thu, Aug 29, 2013 at 01:37:32PM -0700, Jarno Rajahalme wrote:
> On Aug 28, 2013, at 11:55 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > From: Neil Zhu <zhuj at centecnetworks.com>
> > 
> > This doesn't include a dpif implementation of groups functionality.  In its
> > current form, it is untested.  Before this is committed, it needs some
> > more comments and an ovs-ofctl manpage update.
> > 
> > Signed-off-by: Neil Zhu <zhuj at centecnetworks.com>
> > Co-authored-by: Ben Pfaff <blp at nicira.com>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> I did a review and some initial testing. I'll send an incremental patch
> separately for your review. Its all mainly just style issues, but I pointed
> out some real issues below.

I agree with all your comments, thanks.