[ovs-dev] [PATCH] lib: refactor match_format() output functions

[Andy Zhou]

Thanks. Pushed to the master with %#"PRIx32" as suggested.


On Wed, Dec 4, 2013 at 7:57 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Dec 04, 2013 at 12:39:49AM -0800, Andy Zhou wrote:
> > Refactor to remove some duplicated logic in match_format()
> > implemenation and make the output more uniform.
> >
> > Signed-off-by: Andy Zhou <azhou at nicira.com>
>
> I would just use %#"PRIx32" instead of the logic that prints the 0x only
> if the output is more than one decimal digit.  That's clever, but it's
> not what we do anywhere else, and I think that the most likely under-ten
> value is 0, for which %# doesn't print the 0x anyhow.
>
> Otherwise, thanks, this is nicer.
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20131204/be7096ed/attachment-0003.html>