[ovs-dev] [PATCH v5 3/4] lib/flow: Add IPv6 support for flow_compose().

[Ben Pfaff]

On Fri, Dec 06, 2013 at 09:46:29AM -0800, Ben Pfaff wrote:
> On Thu, Dec 05, 2013 at 04:27:25PM -0800, Jarno Rajahalme wrote:
> > Add the missing code for generating IPv6 packets for testing purposes.
> > 
> > Also make flow_compose() set the l4 and l7 pointers more consistently
> > with flow_extract().
> > 
> > Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Would you please use uintptr_t instead of uint64_t here?  Also, I am not
> sure what the comment means.
> > +    ovs_assert((uint64_t)b->l3 % 4 == 0); /* Testing... */

As an aside, Clang warns about this:

    ../lib/flow.c: In function 'flow_compose':
    ../lib/flow.c:1154:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]