[ovs-dev] [PATCH] datapath: Don't allocate space for per-CPU flow stats from cache.

Jesse Gross jesse at nicira.com
Fri Dec 6 21:19:54 UTC 2013


Per-CPU flow stats are now allocated separately (if necessary) so
there's no longer any need to allocate space for them directly in
the base flow.

Signed-off-by: Jesse Gross <jesse at nicira.com>
---
 datapath/flow_table.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/datapath/flow_table.c b/datapath/flow_table.c
index b20adcb..6bb68d8 100644
--- a/datapath/flow_table.c
+++ b/datapath/flow_table.c
@@ -606,15 +606,11 @@ int ovs_flow_tbl_insert(struct flow_table *table, struct sw_flow *flow,
  * Returns zero if successful or a negative error code. */
 int ovs_flow_init(void)
 {
-	int flow_size;
-
 	BUILD_BUG_ON(__alignof__(struct sw_flow_key) % __alignof__(long));
 	BUILD_BUG_ON(sizeof(struct sw_flow_key) % sizeof(long));
 
-	flow_size = sizeof(struct sw_flow) +
-		    (num_possible_cpus() * sizeof(struct sw_flow_stats));
-
-	flow_cache = kmem_cache_create("sw_flow", flow_size, 0, 0, NULL);
+	flow_cache = kmem_cache_create("sw_flow", sizeof(struct sw_flow), 0,
+					0, NULL);
 	if (flow_cache == NULL)
 		return -ENOMEM;
 
-- 
1.8.3.2




More information about the dev mailing list