[ovs-dev] [PATCH 2/2] lib: Determine cpu core count with /proc/cpuinfo

[Joe Stringer]

On 5 December 2013 15:42, Joe Stringer <joestringer at nicira.com> wrote:
> + * Tries not to count hyper-threads, but may be inaccurate - particularly on
> + * platforms that do not provide /proc/cpuinfo, but also if /proc/cpuinfo is
> + * formatted different to the layout that parse_cpuinfo() expects. */

Just highlighting this point. parse_cpuinfo() works for the Xeon, Core
i7 and AMD Bulldozer samples that I found around on the Internet, and
for the lab machine that I use for testing. It can't detect the number
of cores that my VM has, as the format differs from what it expects;
I've looked around at other platforms, and the format differs there
too. In these cases, falling back to sysconf() should suffice. If
there are some specific platforms that we wish to target, which have
multiple threads per core with different /proc/cpuinfo format, then
I'm happy to take /proc/cpuinfo samples and adjust as necessary.