[ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

Ben Pfaff blp at nicira.com
Fri Dec 6 23:42:33 UTC 2013


On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote:
> Ofproto always provides a valid pointer to a mask, but the mask length
> is zero when megaflows are disabled.  Use match_wc_init() to get an
> appropriate exact match mask when there is no mask.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

Does match_wc_init() have the semantics we want?  I would have guessed
that we want to match on every field, or at least every field that is
well-defined by prerequisites, rather than on every field that is
nonzero.

I am less and less sure that match_wc_init() makes sense for anything
other than display to a user.



More information about the dev mailing list