[ovs-dev] [PATCH] bridge: Remove superfluous "inline" from ofp12_controller_role_to_str().

Ethan Jackson ethan at nicira.com
Sat Dec 7 01:09:15 UTC 2013


Could we add a grep for this to the make?

Ethan

On Fri, Dec 6, 2013 at 3:57 PM, Joe Stringer <joestringer at nicira.com> wrote:
> Acked-by: Joe Stringer <joestringer at nicira.com>
>
> On 20 November 2013 16:50, Ben Pfaff <blp at nicira.com> wrote:
>> Putting "static inline" on a function definition in a .c file does not help
>> the compiler and does suppress warnings for unused functions that one would
>> want, should the function ever become unused.
>>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>> ---
>>  vswitchd/bridge.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
>> index 6ce7d2b..33dc738 100644
>> --- a/vswitchd/bridge.c
>> +++ b/vswitchd/bridge.c
>> @@ -2118,7 +2118,7 @@ run_system_stats(void)
>>      }
>>  }
>>
>> -static inline const char *
>> +static const char *
>>  ofp12_controller_role_to_str(enum ofp12_controller_role role)
>>  {
>>      switch (role) {
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list