[ovs-dev] [PATCH] lib: Bypass include_next preprocessor directives on Windows platform

[Alin Serdean]

I would leave it up too you. An easier solution would be to put in the Vstudio includes first(in the case for cccl) because there is no need for the string.h wrapper.

Kind Regards,
Alin.
________________________________________
From: Ben Pfaff [blp at nicira.com]
Sent: Friday, December 06, 2013 10:54 PM
To: Alin Serdean
Cc: Gurucharan Shetty; Alessandro Pilotti; dev at openvswitch.org
Subject: Re: [PATCH] lib: Bypass include_next preprocessor directives on Windows platform

On Fri, Dec 06, 2013 at 12:51:25PM -0800, Ben Pfaff wrote:
> On Fri, Dec 06, 2013 at 07:35:45PM +0000, Alin Serdean wrote:
> > Signed-off-by: Alin Serdean <aserdean at cloudbasesolutions.com>
> > ---
> >  lib/string.h |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/string.h b/lib/string.h
> > index 2b7b454..6981742 100644
> > --- a/lib/string.h
> > +++ b/lib/string.h
> > @@ -17,7 +17,11 @@
> >  #ifndef STRING_WRAPPER_H
> >  #define STRING_WRAPPER_H 1
> >
> > +#ifdef _WIN32
> > +#include <../include/string.h>
> > +#else
> >  #include_next <string.h>
> > +#endif
> >
> >  /* Glibc 2.7 has a bug in strtok_r when compiling with optimization that can
> >   * cause segfaults if the delimiters argument is a compile-time constant that
>
> include_next.m4 would be a more portable solution, I think:
>         http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=m4/include_next.m4

I'm happy to write up a patch to use that, by the way, if you think
it's a reasonable approach.  (I realize that gnulib and Autoconf can
be more than a little baffling sometimes.)