[ovs-dev] [PATCH] datapath: Fix sparse warning.

[Pravin Shelar]

On Wed, Dec 11, 2013 at 10:51 AM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> Make the new compat function skb_flow_get_ports() static to silence a
> sparse warning.
>
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> ---
>  datapath/linux/compat/flow_dissector.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath/linux/compat/flow_dissector.c b/datapath/linux/compat/flow_dissector.c
> index 7a0d09b..a8a2e52 100644
> --- a/datapath/linux/compat/flow_dissector.c
> +++ b/datapath/linux/compat/flow_dissector.c
> @@ -46,7 +46,7 @@ static void iph_to_flow_copy_addrs(struct flow_keys *flow, const struct iphdr *i
>         memcpy(&flow->src, &iph->saddr, sizeof(flow->src) + sizeof(flow->dst));
>  }
>
> -__be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto)
> +static __be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto)
>  {
>         int poff = proto_ports_offset(ip_proto);
>
> --

Looks good.

Acked-by: Pravin B Shelar <pshelar at nicira.com>

> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev