[ovs-dev] [bug15637 v2 1/2] ovsdb-client: Make "monitor" command able to monitor all tables.

Ben Pfaff blp at nicira.com
Fri Dec 13 22:10:33 UTC 2013


On Wed, Nov 27, 2013 at 02:58:13PM -0800, Alex Wang wrote:
> +    if (get_detach()) {
> > +        int error;
> > +
> > +        error = unixctl_server_create(NULL, &unixctl);
> > +        if (error) {
> > +            ovs_fatal(error, "failed to create unixctl server");
> > +        }
> > +
> > +        unixctl_command_register("exit", "", 0, 0,
> > +                                 ovsdb_client_exit, &exiting);
> > +        unixctl_command_register("ovsdb-client/block", "", 0, 0,
> > +                                 ovsdb_client_block, &blocked);
> > +        unixctl_command_register("ovsdb-client/unblock", "", 0, 0,
> > +                                 ovsdb_client_unblock, &blocked);
> > +    } else {
> > +        unixctl = NULL;
> >      }
> >
> 
> 
> 1. Should we also check get_pidfile here?  Since otherwise, we won't have a
> target.

I admit that it is less convenient to control a process that lacks a
pidfile, but it is still possible if you specify the full path to the
unixctl socket.

> 2. In order to monitor all table, I really need to maximize the terminal
> screen and minimize the font,
>     since there are so many columns in a row.  Seems to me that I cannot
> specify columns when
>     'monitor ALL', because there is hardly any column shared by all tables.
>  Are these the intended
>     behavior.

I guess that, if you don't really want to monitor everything in all
the tables, you should specify exactly what you want to monitor.

Thanks,

Ben.



More information about the dev mailing list