[ovs-dev] [PATCH] rconn: Update comments on is_admitted_msg().

[Alex Wang]

Looks good to me,


On Mon, Dec 16, 2013 at 9:24 AM, Ben Pfaff <blp at nicira.com> wrote:

> This could use a review (should be easy).
>
> On Thu, Nov 21, 2013 at 03:03:43PM -0800, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/rconn.c |   12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/rconn.c b/lib/rconn.c
> > index f7f90f7..6c96fe0 100644
> > --- a/lib/rconn.c
> > +++ b/lib/rconn.c
> > @@ -1349,6 +1349,17 @@ is_connected_state(enum state state)
> >      return (state & (S_ACTIVE | S_IDLE)) != 0;
> >  }
> >
> > +/* When a switch initially connects to a controller, the controller may
> spend a
> > + * little time examining the switch, looking at, for example, its
> datapath ID,
> > + * before it decides whether it is willing to control that switch.  At
> that
> > + * point, it either disconnects or starts controlling the switch.
> > + *
> > + * This function returns a guess to its caller about whether 'b' is
> OpenFlow
> > + * message that indicates that the controller has decided to control the
> > + * switch.  It returns false if the message is one that a controller
> typically
> > + * uses to determine whether a switch is admissible, true if the
> message is one
> > + * that would typically be used only after the controller has admitted
> the
> > + * switch. */
> >  static bool
> >  is_admitted_msg(const struct ofpbuf *b)
> >  {
> > @@ -1370,7 +1381,6 @@ is_admitted_msg(const struct ofpbuf *b)
> >      case OFPTYPE_GET_CONFIG_REQUEST:
> >      case OFPTYPE_GET_CONFIG_REPLY:
> >      case OFPTYPE_SET_CONFIG:
> > -        /* FIXME: Change the following once they are implemented: */
> >      case OFPTYPE_QUEUE_GET_CONFIG_REQUEST:
> >      case OFPTYPE_QUEUE_GET_CONFIG_REPLY:
> >      case OFPTYPE_GET_ASYNC_REQUEST:
> > --
> > 1.7.10.4
> >
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20131216/e372c122/attachment-0003.html>