[ovs-dev] [PATCH] ofproto/trace: Fix memory leak on error path.

Jarno Rajahalme jrajahalme at nicira.com
Mon Dec 16 23:09:30 UTC 2013


Augmented as suggested and pushed to master, thanks for the review!

  Jarno

On Dec 16, 2013, at 9:47 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Tue, Dec 03, 2013 at 03:04:31PM -0800, Jarno Rajahalme wrote:
>> Propagate error response from parse_ofp_exact_flow() to the caller and
>> properly free() it afterward.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> I have a habit of marking functions that return a string that must be
> freed as WARN_UNUSED_RESULT.  Sometimes it catches mistakes.  Can we
> mark parse_flow_and_packet() this way?
> 
> Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list