[ovs-dev] [PATCH] Update openvswitch to allow linking from C++ projects

Ben Pfaff blp at nicira.com
Tue Dec 17 04:55:10 UTC 2013


I think that this should be three patches, since it does three things
that don't seem related to me.

On Mon, Dec 16, 2013 at 06:57:40PM -0800, Harold Lim wrote:
> 1. libopenvswitch is updated to be compiled with -fPIC.

Why?  C++ doesn't require -fPIC as far as I know.

> 2. The input variable of ovs_scan is changed from 'template' to
>    'format'. template is a keyword in C++.

OK, that makes sense.

> 3. Add an #ifndef guard around NOT_REACHED.

Why?  C++ doesn't define a NOT_REACHED macro or other identifier as far
as I know.



More information about the dev mailing list