[ovs-dev] [PATCH v4.3 4/5] ofproto: handle OFPMP_TABLE_FEATURES msgs and its lifecycle.

[Ben Pfaff]

On Mon, Dec 09, 2013 at 06:41:12PM +0800, Alexander Wu wrote:
> v4.3:
>   Fix last table features id to 253 according to current
>   imlement and OpenFlow spec.
> 
> v4.2:
>   Fix last table features id to 255.
> 
> v4:
>   1. update abstract table-features to bitmap
>   2. update ofproto, reduce copy when reply table features.
>   3. Move max_table_feature to oftable.
> 
> v3:
>   1. Delete variable OFPIT13_END, use OFPIT13_METER directly.
>   2. Fix implement, restructure with macro.
>   3. Add comments that describe table-features-set message is not
>      implement yet.
>   4. Update calls from ofp-util.
>   5. Update comments of action-init.
>   6. Add description for table-features get/set struct.
> 
> v2:
>   1. fix function align, align to 79 bytes, fix BE64 to UINT64, etc.
>   2. fix n_tables_miss init type.
>   3. Change calls from ofputil.
> 
> v1:
>   Add table_feature structs in ofproto && oftable to initialize.
>   The struct in ofproto is used to get
>   The struct in oftable is used to set (set is not implement yet)
> 
>   Add some functions to init table features(use ofp13_* struct
>   currently, change it to ofputil later).
>   Use the encode/decode functions to handle table features request.
> 
>   Currently we just implement GET table feature.
>   SET table feature may be a hard job, we'll do it later.
> 
> Signed-off-by: Alexander Wu <alexander.wu at huawei.com>
> 
> ofproto

Clang reports:

    ../lib/ofp-actions.c:1655:16: error: implicit conversion from enumeration type 'enum ofperr' to different enumeration type 'enum ovs_instruction_type' [-Werror,-Wenum-conversion]
            return OFPERR_OFPTFFC_BAD_ARGUMENT;
            ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    ../lib/ofp-print.c:2289:1: error: unused function 'ofp_print_not_implemented' [-Werror,-Wunused-function]
    ofp_print_not_implemented(struct ds *string)
    ^
    1 error generated.
    ../ofproto/ofproto.c:5988:13: error: calling function 'table_features_set' requires exclusive lock on 'ofproto_mutex' [-Werror,-Wthread-safety-analysis]
                table_features_set(ofproto, &request_features[i]);
                ^

Thanks,

Ben.